Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'BuildDependencyTree' for Conan #136

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Implement 'BuildDependencyTree' for Conan #136

merged 4 commits into from
Aug 8, 2024

Conversation

igorz-jf
Copy link
Contributor

@igorz-jf igorz-jf commented Aug 7, 2024 •
edited by attiasas
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. (internal changes)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@igorz-jf
Copy link
Contributor Author

igorz-jf commented Aug 7, 2024

I have read the CLA Document and I hereby sign the CLA

@attiasas attiasas self-requested a review August 7, 2024 08:28
@attiasas attiasas added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request labels Aug 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 7, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 7, 2024
attiasas
attiasas requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!, please take a look at my comments.

  1. Please add description to the PR
  2. add integration tests at audit_test.go for conan project with security issue

.github/workflows/test.yml Outdated Show resolved Hide resolved
commands/audit/sca/conan/conan.go Outdated Show resolved Hide resolved
commands/audit/sca/conan/conan.go Outdated Show resolved Hide resolved
commands/audit/sca/conan/conan.go Show resolved Hide resolved
commands/audit/sca/conan/conan.go Outdated Show resolved Hide resolved
commands/audit/sca/conan/conan.go Outdated Show resolved Hide resolved
commands/audit/sca/conan/conan_test.go Outdated Show resolved Hide resolved
@attiasas attiasas changed the title Implement 'BuildDependencyTree' for Conan Audit - Conan technology support Aug 8, 2024
@attiasas attiasas changed the title Audit - Conan technology support Implement 'BuildDependencyTree' for Conan Aug 8, 2024
@attiasas attiasas added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request and removed new feature Automatically generated release notes labels Aug 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 8, 2024
@attiasas attiasas self-requested a review August 8, 2024 11:34
attiasas
attiasas reviewed Aug 8, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Aug 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

@attiasas attiasas merged commit 5e8f4d8 into jfrog:dev Aug 8, 2024
6 of 9 checks passed
attiasas pushed a commit that referenced this pull request Aug 11, 2024
@igorz-jf
Fix issues from PR #136 (#140)
c7d7688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorz-jf @attiasas