Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run GH Actions on windows as well #9540

Merged
merged 4 commits into from
Feb 11, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Feb 9, 2020

Summary

Follow-up from #9101. Not sure why the tests are failing...

Test plan

Green CI at some point

@codecov-io
Copy link

codecov-io commented Feb 9, 2020

Codecov Report

Merging #9540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9540   +/-   ##
=======================================
  Coverage   65.04%   65.04%           
=======================================
  Files         286      286           
  Lines       12123    12123           
  Branches     3004     3004           
=======================================
  Hits         7885     7885           
  Misses       3600     3600           
  Partials      638      638

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d59561...e6fe42e. Read the comment docs.

@SimenB
Copy link
Member Author

SimenB commented Feb 11, 2020

node 13 on windows reports #9544
image

Would be nice to land this...

runs-on: ${{ matrix.os }}

steps:
- name: Set git config
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB
Copy link
Member Author

SimenB commented Feb 11, 2020

🎉

@SimenB SimenB merged commit 47b8aae into jestjs:master Feb 11, 2020
@SimenB SimenB deleted the gh-actions-windows branch February 11, 2020 15:54
@SimenB SimenB mentioned this pull request May 9, 2020
4 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants