Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade jest-snapshot#semver to v6 to support node 8 #9451

Merged
merged 3 commits into from
Jan 23, 2020
Merged

chore: downgrade jest-snapshot#semver to v6 to support node 8 #9451

merged 3 commits into from
Jan 23, 2020

Conversation

grxy
Copy link
Contributor

@grxy grxy commented Jan 23, 2020

Summary

Downgrades the semver dependency in jest-snapshot to a version that supports node 8.

Fixes #9450

Test plan

N/A

@grxy grxy marked this pull request as ready for review January 23, 2020 05:24
@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #9451 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9451   +/-   ##
=======================================
  Coverage   64.96%   64.96%           
=======================================
  Files         283      283           
  Lines       12104    12104           
  Branches     2990     2990           
=======================================
  Hits         7863     7863           
  Misses       3604     3604           
  Partials      637      637

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7817dcc...49904b1. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Jan 23, 2020

Whoops, my bad! I read "Drop support for very old node versions" in the changelog which was before 8 was EOL and just assumed it didn't include node 8

@@ -92,7 +92,7 @@
"lint:prettier": "yarn --silent lint:prettier:ci --fix",
"lint:prettier:ci": "prettylint '**/*.{md,yml,yaml}' --ignore-path .gitignore",
"postinstall": "opencollective postinstall && yarn build",
"install-no-ts-build": "node scripts/remove-postinstall && yarn --no-progress --frozen-lockfile --ignore-engines && node scripts/build",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hid the error. not sure why we even had it here...

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit 8607684 into jestjs:master Jan 23, 2020
@grxy grxy deleted the grex/jest-snapshot-semver-fix branch January 25, 2020 15:51
@Methuselah96
Copy link
Contributor

@SimenB Are there plans to release this in a patch release soon?

@SimenB
Copy link
Member

SimenB commented Jan 27, 2020

I wanna get #9457 fixed first, then I'll start poking people for a patch release. It's unfortunately a lot of work getting a release out 🙁 You can use --ignore-engines or resolutions in the meantime to get unblocked

@Methuselah96
Copy link
Contributor

@SimenB Thanks for the reply; sounds good. I'm asking on behalf of a library that depends on Jest and I'm trying to upgrade its dependencies in an effort to make it compatible with Jest v25, so unfortunately I can't use --ignore-engines or resolutions. I'll just have to wait until a patch release is published to make it compatible with Jest 25. Thanks for your hard work!

@DanielSchuech
Copy link

Any update about a new release? #9457 seems not to be an easy fix and there are no comments since 22 days. We would like to upgrade our dependecies without the resolutions workaround.

@SimenB
Copy link
Member

SimenB commented Mar 25, 2020

25.2.0 published

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jest-snapshot v25 requires a version of semver which doesn't support node 8
6 participants