Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor requireAndTranspileModule to use exts from moduleFileExtenstions #8895

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

Mark1626
Copy link
Contributor

Summary

In the current implementation of requireAndTranspileModule the extensions used for pirates is determined by path.extname. path.extname returns empty string for directories, which resulted in PnP test failing in #8854. Restricting the extensions to the ones specified in moduleFileExtensions

/cc @SimenB @jeysal

Test plan

Existing tests should not break
All PRs related to #8810 should not be affected

@codecov-io
Copy link

Codecov Report

Merging #8895 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8895      +/-   ##
==========================================
- Coverage   64.21%   64.21%   -0.01%     
==========================================
  Files         275      275              
  Lines       11657    11658       +1     
  Branches     2847     2847              
==========================================
  Hits         7486     7486              
- Misses       3545     3546       +1     
  Partials      626      626
Impacted Files Coverage Δ
packages/jest-transform/src/ScriptTransformer.ts 68.77% <0%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95688ac...c591971. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, perfect

@SimenB SimenB merged commit 45c57c5 into jestjs:master Aug 30, 2019
@Mark1626 Mark1626 deleted the transform-hook-exts branch August 31, 2019 08:56
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants