Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enforce LF line endings #8809

Merged
merged 3 commits into from
Aug 11, 2019
Merged

chore: enforce LF line endings #8809

merged 3 commits into from
Aug 11, 2019

Conversation

jeysal
Copy link
Contributor

@jeysal jeysal commented Aug 11, 2019

Summary

Fixes #8788.

Test plan

eslint-plugin-prettier / prettylint lint / autofix this for us.

@@ -86,8 +86,8 @@
"jest-coverage": "yarn jest --coverage",
"lint": "eslint . --cache --report-unused-disable-directives --ext js,jsx,ts,tsx,md",
"lint-es5-build": "eslint --no-eslintrc --no-ignore --env=browser packages/*/build-es5",
"lint:md": "yarn --silent lint:md:ci --fix",
"lint:md:ci": "prettylint '**/*.{md,yml,yaml}' --ignore-path .gitignore",
"lint:prettier": "yarn --silent lint:prettier:ci --fix",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I'd also rename the script while on it since it's no longer just md. Simen mentioned this name being misleading some time ago.

@@ -1,11 +1,17 @@
# EditorConfig helps developers define and maintain consistent
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this pretty much looks like the typical editorconfig examples, except for the md/snap override

@SimenB
Copy link
Member

SimenB commented Aug 11, 2019

Enforce LF from prettier config as well? Or does prettier read the editorconfig?

@jeysal
Copy link
Contributor Author

jeysal commented Aug 11, 2019

Yes, prettier understands a few editorconfig settings https://prettier.io/docs/en/api.html#prettierresolveconfigfilepath-options

@jeysal
Copy link
Contributor Author

jeysal commented Aug 11, 2019

(verified it by running lint --fix, which made the eol changes present in this PR)

@pedrottimark
Copy link
Contributor

Super! What do you think about a comment in editor config file to make the assumption explicit?

@jeysal
Copy link
Contributor Author

jeysal commented Aug 11, 2019

@pedrottimark sure, why not - fine with that which I just added?

Copy link
Contributor

@pedrottimark pedrottimark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for keeping the repo on a firm foundation to receive contributions from the community

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does Jest repo need .gitattributes file?
4 participants