Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expect: Throw matcher error when received cannot be jasmine spy #8747

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Jul 24, 2019

Summary

Throw matcher error from *Return* matchers if received is a spy function, instead of TypeError: received.getMockName is not a function

  • Change isSpy function to test for both all and count methods
  • Rename ensureMock as ensureMockOrSpy for *Call* matchers
  • Add ensureMock function for *Return* matchers

EDIT: Jasmine spy functions do not provide information about return values

Test plan

  • Defined createSpy in test file to return a mock of a spy function, because jasmine.createSpy is not defined when jest-circus is the test runner
  • Added 10 passing positive and negative *Called* assertions with spy functions
  • Replaced 4 failing positive and negative *Called* assertions with spy functions
  • Updated 8 and removed 2 snapshots of matcher errors for *Return* assertions with ordinary function
  • Added 4 snapshots of matcher errors for *Return* assertions with spy functions

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jasmine spy functions do not provide information about return values

Ahh, that made clear why we're doing this 😄 LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@pedrottimark pedrottimark changed the title expect: Improve report when mock-spy matcher fails, part 5 expect: Throw matcher error when received cannot be jasmine spy Jul 25, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants