Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use testPathPattern as a filter on top of findRelatedTests #8311

Closed
wants to merge 22 commits into from
Closed

Use testPathPattern as a filter on top of findRelatedTests #8311

wants to merge 22 commits into from

Commits on Apr 11, 2019

  1. Configuration menu
    Copy the full SHA
    92837e0 View commit details
    Browse the repository at this point in the history
  2. null check testPathPattern and eventually get around to fixing failin…

    …g unit tests
    Mack Solomon committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    808564a View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Configuration menu
    Copy the full SHA
    f7eafee View commit details
    Browse the repository at this point in the history
  2. remove unnecessary code

    Mack Solomon committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    5eddcbd View commit details
    Browse the repository at this point in the history
  3. update _filterTestPathsWithStats condition

    We only want to _filterTestPathsWithStats if testPathPattern was
    explicitly passed as an argument. The issue is that it's not possible to
    simply null check globalConfig.testPathPattern to determine if it was
    explicity passed becase that field gets populated with values passed to
    findRelatedTests also. This approach compares the values in
    globalConfig.testPathPattern to the values in globalConfig.nonFlagArgs
    and if it is a 1 to 1 match it is assumed that testPathPattern was not
    explicity passed as an argument.
    Mack Solomon committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    d83b4c6 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2019

  1. Configuration menu
    Copy the full SHA
    7ee3e54 View commit details
    Browse the repository at this point in the history
  2. fix linting issues

    Mack Solomon committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    9d7aed1 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. fix instances of findRelatedTests

    findRelatedTests used to be a boolean field. It has been updated to be Array<string>. We will check the length of the array to determine if findRelatedTests is falsy or truthy since 0 will evaluate to false and aything greater than 0 will evaluate to true.
    mackness committed Apr 24, 2019
    1 Configuration menu
    Copy the full SHA
    813fab3 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. Configuration menu
    Copy the full SHA
    b9ad8bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2613dd0 View commit details
    Browse the repository at this point in the history
  3. fix failing normalize spec

    mackness committed May 4, 2019
    Configuration menu
    Copy the full SHA
    17b4310 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2019

  1. Configuration menu
    Copy the full SHA
    f95a0d4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bfa2569 View commit details
    Browse the repository at this point in the history
  3. lockfile

    mackness committed Jun 2, 2019
    Configuration menu
    Copy the full SHA
    a85dd4b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4e99139 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4169622 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9c001f7 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2019

  1. add a simple --testPathPattern assertion

    simple test that asserts --testPathPattern will filter tests matched by --findRelatedTests
    mackness committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    144e6f0 View commit details
    Browse the repository at this point in the history
  2. disable prefer-const rule

    mackness committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    e73ecd7 View commit details
    Browse the repository at this point in the history
  3. disable no-unresolved rule for fsevents

    for some reason this lint command works locally but fails in CI
    
    eslint . --cache --report-unused-disable-directives --ext js,jsx,ts,tsx,md --format junit -o reports/junit/js-lint-results.xml
    mackness committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    c33284d View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2019

  1. Configuration menu
    Copy the full SHA
    a938c25 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7dc3269 View commit details
    Browse the repository at this point in the history