Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump package versions #6978

Merged
merged 2 commits into from
Sep 19, 2018
Merged

chore: bump package versions #6978

merged 2 commits into from
Sep 19, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Sep 13, 2018

Summary

Packages bumped are mostly "drop node 4" or not breaking changes.

Left out Babel stuff (#6949) and jsdom (which requires node 8)

Test plan

Green CI 😀

@@ -13,7 +13,7 @@ exports[`custom transformer instruments files 1`] = `
"----------|----------|----------|----------|----------|-------------------|
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files | 0 | 0 | 0 | 0 | |
All files | Unknown | Unknown | Unknown | Unknown | |

This comment was marked as resolved.

@@ -8,10 +8,10 @@
"license": "MIT",
"main": "build/index.js",
"dependencies": {
"@babel/code-frame": "^7.0.0-beta.35",
"@babel/code-frame": "7.0.0-beta.44",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last version with node 4 support. Upgrading it to 7 stable breaks the browser build... not sure why TBH, didn't dig into it

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we definitely drop Node 4 support, or do we still secretly support it?

package.json Outdated Show resolved Hide resolved
@@ -21,7 +21,6 @@ function createProcessEnv() {
return deepCyclicCopy(process.env);
}

// $FlowFixMe: Apparently Flow does not understand that this is a prototype.
const proto: Object = Object.getPrototypeOf(process.env);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to annotate this with Object type or will Flow now infer that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we need it

image

@SimenB
Copy link
Member Author

SimenB commented Sep 19, 2018

Did we definitely drop Node 4 support, or do we still secretly support it?

We've dropped it, I think? This will just go out in Jest 24 anyways, so no biggie

@thymikee
Copy link
Collaborator

Cool, we've supported it for quite a long time after EOL anyway

@codecov-io
Copy link

Codecov Report

Merging #6978 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6978      +/-   ##
==========================================
- Coverage   66.93%   66.92%   -0.01%     
==========================================
  Files         250      250              
  Lines       10405    10405              
  Branches        4        3       -1     
==========================================
- Hits         6965     6964       -1     
- Misses       3439     3440       +1     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-util/src/create_process_object.js 100% <ø> (ø) ⬆️
packages/jest-runtime/src/script_transformer.js 84.57% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3dc90f...b164e47. Read the comment docs.

@SimenB SimenB merged commit 41e0da0 into jestjs:master Sep 19, 2018
@SimenB SimenB deleted the package-bump branch September 19, 2018 12:00
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants