Unescape serialized snapshots for diffing

[thymikee]

Summary

This is a followup of #2731.

I didn't want to alter serialisation improvements which @vjeux introduced, so I thought it would be safer to bring back an unescape in a little different form and use it only to generate un-escaped output to diff tool. Thanks to this we avoid having extra backslashes in console output.

Given test:

test('snap', () => {
  expect('coca cola "yoko \\son (*)\d o".').toMatchSnapshot();
  expect(/some-regex('\"\))\\.x/).toMatchSnapshot();
});

Before:

After:

Test plan

jest
cc: @cpojer @vjeux

[thymikee]

@vjeux I thought a bit about evaling these snapshot, but it would be problematic for jsx and regexp at least. We also cannot really use received instead receivedSerialized for diffing, because the latter is processed through pretty-format with all the React plugins.

I know it's not ideal, but it works for now 🤷‍♂️

[cpojer]

wait, do we really need to do this? Doesn't this also unescape strings that have regex characters in them?

[thymikee]

yes it will, that's why I stated it's not ideal

[thymikee]

We could avoid unescaping regex, it will result in many backslashes, but it's still gonna be usable.

[cpojer]

Yeah, I think we should not do this for now. Let's consider doing this later.

[thymikee]

@rubenmoya We're kind of rushing things for the next release, hence we decided to rebase your commit and apply it here as you were not responding for couple of days, so I'm sorry! (but we made sure to put your name on the commit!)

And I'm thankful for your work, it's great. Hope we'll get to merge something from you in the future 🙂

[rubenmoya]

@thymikee completely understandable, don't worry about my commit ^^ and I hope it too, I wish I had the same knowledge as I have motivation :)

[thymikee]

Keep getting knowledge while you're motivated and make it a habit so you can keep doing it when motivation passes :)

[cpojer]

wow our travis queues are really fucked.

[cpojer]

I'm gonna merge this and deal with a fix on master if necessary.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.