Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace pretty-format/ConvertAnsi with jest-serializer-ansi-escapes #12935

Merged
merged 4 commits into from
Jul 7, 2022
Merged

chore: replace pretty-format/ConvertAnsi with jest-serializer-ansi-escapes #12935

merged 4 commits into from
Jul 7, 2022

Conversation

mrazauskas
Copy link
Contributor

@mrazauskas mrazauskas commented Jun 13, 2022

Summary

For one project I needed to have snapshots with ANSI colors. pretty-format/ConvertAnsi serialiser was not working in this case, because it is only replacing ANSI escapes originating from ansi-styles (also used by chalk). In other words, in the project I have sequences like '\u001b[1;31mSample text' (bold and red), but in similar case ansi-styles would emit \u001b[1m\u001b[31mSample text.

After writing a serialiser for vanilla ANSI escapes, I wanted to tryout out on Jest repo. It did not work with cursor control sequences. Oh.. That’s niche case, but interesting one! So the serialiser is now replacing cursor controls as well: <eraseLine>, <moveCursorToColumn1>, etc. See the snapshots for more.


This is how jest-serializer-ansi-escapes was born. Looks useful. Opening a PR to hear some feedback (;

Test plan

Green CI.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants