ProjectConfig.name to ProjectConfig.id

[jhalak27]

Changed name: string to id: string in file jest/packages/jest-types/src/Config.ts
and in jest/packages/jest-config/src/normalize.ts

Summary

Closes #10013

Test plan

[jeysal]

Hi again, looking good so far but seems you'll also need to update some test - see CI failures

[jhalak27]

Yeah, actually. I wanted to ask whether I should change in those files also? I was afraid to change without asking as these are the test files which needs change.

[jeysal]

Yeah, the tests should also check for the new name 🙃

[jeysal]

Let me know once you have this passing and ready (or of course if you need any further help) :)

[jhalak27]

@jeysal Hey, I am unable to figure out the remaining errors. Could you help in that?

[jeysal]

Hi, so if you look at e.g. the multiProjectRunner.test.ts, you'll see that there is a config object that still has name: 'something' in it. Something like this is probably the problem for all of the tests.
If you change that to id and ideally also add an as Config.InitialOptions to the config object so that the type checker can prevent something like this from happening in the future, that should work :)

[jhalak27]

@jeysal I am not able to find the objects which still has name. Is there anything I am missing?

[jeysal]

For the example I mentioned, it's right there in multiProjectRunner.test.ts 🙈 just search for name in that file and you'll find some 😅

[jhalak27]

I did change every name to id in multiProjectRunner.test.ts in the last commit I made. I search all again, but couldn't find. There are just displayName. sweat_smile

[jeysal]

Oh sorry, must have missed that commit

[jeysal]

So the reason why that test is still not working is probably that groupOptions in jest-config/src/index still has name.
Some other tests still fail or cause warnings because they specify name instead of id somewhere. E.g. lots of warnings from jest-runtime are caused because its tests all use the createRuntime.js helper which still specifies name.
I'm afraid I can't point you to every single occurrence (because if I did, I'd have to invest more time than if I just made the changes myself on the go), but if you can get most of the things out of the way I can help with any few remaining errors that are particularly hard to find or hidden in complex tests.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.