Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest-console): migrate function signature #10126

Merged
merged 3 commits into from
Nov 15, 2020

Conversation

ychi
Copy link
Contributor

@ychi ychi commented Jun 4, 2020

Summary

PR for #10112
The breaking changes to getConsoleOutput: removing unused parameter, making new parameters mandatory.

Test plan

Pass existing test cases.

@SimenB SimenB added this to the Jest 27 milestone Jun 23, 2020
@SimenB
Copy link
Member

SimenB commented Jun 23, 2020

Thanks! Stuck it in the milestone so we don't forget 🙂

@SimenB
Copy link
Member

SimenB commented Nov 14, 2020

@ychi CI is very unhappy - could you rebase this?

@ychi ychi force-pushed the migrate-getconsoleoutput-signature branch from b1476b4 to fae4c87 Compare November 14, 2020 22:04
@ychi
Copy link
Contributor Author

ychi commented Nov 14, 2020

Rebased; looks like latest macOS image is lacking Mercurial?

@SimenB
Copy link
Member

SimenB commented Nov 15, 2020

Thanks!

Rebased; looks like latest macOS image is lacking Mercurial?

There's some unrelated macOS flake - I need to look into that

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry?

@SimenB SimenB changed the title Migrate function signature chore(jest-console): migrate function signature Nov 15, 2020
@SimenB SimenB merged commit a9d2bb1 into jestjs:master Nov 15, 2020
@ychi
Copy link
Contributor Author

ychi commented Nov 15, 2020

Added to Chore & Maintenance section 🙂

@ychi ychi deleted the migrate-getconsoleoutput-signature branch November 15, 2020 13:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants