Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerate RuntimeException from SCMListener.onCheckout #51

Merged
merged 1 commit into from
May 10, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented May 6, 2021

jenkinsci/github-checks-plugin#161 ought not to have caused a build failure.

@jglick jglick requested a review from bitwiseman May 6, 2021 12:49
@jglick jglick requested review from dwnusbaum and rsandell May 6, 2021 12:49
@dwnusbaum dwnusbaum requested a review from car-roll May 6, 2021 13:50
@jglick
Copy link
Member Author

jglick commented May 6, 2021

BTW it is uncomfortable to try to guess who the current maintainer of a plugin is. Recommend using CODEOWNERS with a GitHub group: https://github.com/jenkinsci/archetypes/blob/f5d4f255388600560bfe02feee5d94b837593d9c/common-files/.github/CODEOWNERS

@car-roll
Copy link
Contributor

well guess i'm not a maintainer since i don't have any merge permissions 😄

@dwnusbaum
Copy link
Member

@car-roll You should have permissions now.

@car-roll car-roll merged commit 40970db into jenkinsci:master May 10, 2021
@jglick jglick deleted the onCheckout branch May 10, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants