-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-71715] Update minimum supported Jenkins version to 2.440 to be able to use new ConsoleUrlProvider
API to link to Pipeline build console page
#373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
dwnusbaum
commented
Aug 21, 2023
timja
reviewed
Jan 20, 2024
ready to go @dwnusbaum? |
@timja Yeah I was just waiting for the new LTS to drop; I'll try to update all of the related PRs this week. |
dwnusbaum
changed the title
[JENKINS-71715] Use new ConsoleUrlProvider API to link to Pipeline build console page
[JENKINS-71715] Update minimum supported Jenkins version to 2.440 to be able to use new ConsoleUrlProvider API to link to Pipeline build console page
Jan 29, 2024
dwnusbaum
changed the title
[JENKINS-71715] Update minimum supported Jenkins version to 2.440 to be able to use new ConsoleUrlProvider API to link to Pipeline build console page
[JENKINS-71715] Update minimum supported Jenkins version to 2.440 to be able to use new Jan 29, 2024
ConsoleUrlProvider
API to link to Pipeline build console page
jglick
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sanity tested recently?
Yes, I just added a new video to the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-71715 and jenkinsci/jenkins#8321.
Testing done
Tested in combination with jenkinsci/pipeline-input-step-plugin#145 and jenkinsci/pipeline-graph-view-plugin#289, see this video:
Screen.Recording.2024-01-29.at.3.03.32.PM.mov
Submitter checklist