-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Log handling rewrite modifications #108
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for getLogFile().
…y encompassing all of the functionality of jenkinsci#21.
Also using jitpack and linking to jenkinsci/maven-hpi-plugin#46 & jenkinsci/workflow-api-plugin#17 & jenkinsci/workflow-support-plugin#15.
Unfortunately it is also necessary to <exclude> the official dependency GAs to avoid duplication, which seems like a fundamental limitation of jitpack.io as applied to Maven.
…Node.iterateEnclosingBlocks.
…rly accessed directly.
…nt which I think would need a patch to workflow-cps to handle properly.
…even when the overall build is long.
…tep logs, even for steps running across the upgrade. In this example, log is complete and the raw log is identical to what it would have been without an upgrade; the first echo step and the sleep step use LogActionImpl and have complete *.log files; the second echo step uses LogStorageAction and log-index records its range.
… should be idempotent.
…Also reduce scope of lock.
…gered CI-only failures
So probably just some sort of race condition. |
FTR this is also jglick#3, but filed properly against the origin repo so that we get CI on it. |
For whatever reason, what should be a trivial fix is not, and oddly the original does not trigger failures, so... I guess we roll with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #27 -- do not merge yet (there's a direct PR to that branch open)