[JENKINS-52189] Ensure GraphListeners are notified of the FlowStartNode too #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanoort
commented
Jul 2, 2018
| @@ -117,6 +117,19 @@ void newStartNode(FlowStartNode n) throws IOException { | |||
| this.head = execution.startNodes.push(n); | |||
| } | |||
| execution.storage.storeNode(head, false); | |||
|
|
|||
| CpsThreadGroup c = CpsThreadGroup.current(); | |||
| if (c !=null) { | |||
There was a problem hiding this comment.
I'm leaving this in, in case we do get a proper CpsThreadGroup down the road, so it does The Right Thing (tm).
abayer
approved these changes
Jul 2, 2018
|
This will currently not work for It is obviously possible to use a global extension, but I was under the impression that |
|
Note: might solve a minor display issue in logs that I noticed in JEP-210 (see #252), that we display the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-52189
We might consider initializing the CpsThreadGroup before the FlowStartNode (in CpsFlowExecution) to make this more "correct" but I'm a bit concerned that might have unintended consequences.