Introduce bom and bump minimum required version #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to http://stats.jenkins.io/pluginversions/workflow-cps-global-lib.html 98% of users on the latest version are on this version or above 88% on the previous version are on this version or above 97% on the previous version are on one of the previous LTS releases in this line and could likely easily upgrade
timja
commented
Apr 9, 2020
| <subversion-plugin.version>2.13.0</subversion-plugin.version> | ||
| <workflow-scm-step-plugin.version>2.7</workflow-scm-step-plugin.version> | ||
| <workflow-multibranch-plugin.version>2.21</workflow-multibranch-plugin.version> |
There was a problem hiding this comment.
needs adding to bom, will try take a look, but shouldn't block this
There was a problem hiding this comment.
Included in jenkinsci/bom#179, FYI.
jglick
approved these changes
Apr 9, 2020
| <subversion-plugin.version>2.13.0</subversion-plugin.version> | ||
| <workflow-scm-step-plugin.version>2.7</workflow-scm-step-plugin.version> | ||
| <workflow-multibranch-plugin.version>2.21</workflow-multibranch-plugin.version> |
There was a problem hiding this comment.
Included in jenkinsci/bom#179, FYI.
pom.xml
Outdated
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> |
recommendedConfigurations is unusable on recent LTS :( ref jenkins-infra/pipeline-library#94
|
Could someone else resubmit this due to needing to change the jenkinsfile bff6324 |
|
Merged after commons-lang removal but will need someone with write access to re-submit this, or yolo merge |
Merged
check #97 |
dwnusbaum
reviewed
Apr 13, 2020
Or just look in the build log, as of jenkinsci/maven-hpi-plugin#130 |
|
Also tests are broken: https://ci.jenkins.io/job/Plugins/job/workflow-cps-global-lib-plugin/job/PR-97/1/testReport/ |
dwnusbaum
reviewed
Apr 13, 2020
Requires plugin versions bumped above trilead split which would require a baseline of at least 2.190.x
|
Can't build against 2.222.x unless we bump to 2.190.x as minimum due to trilead-api problems in other dependencies. |
|
Build passed |
bitwiseman
approved these changes
Apr 13, 2020
|
This looks good to me. Just |
|
Yup |
dwnusbaum
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to http://stats.jenkins.io/pluginversions/workflow-cps-global-lib.html
98% of users on the latest version are on this version or above
88% on the previous version are on this version or above
97% on the previous version are on one of the previous LTS releases in
this line and could likely easily upgrade
When testing #94 I was unable to test it interactively due to conflicts in plugin loading, ssh-credentials and git both failed to load. With these changes I was able to test it
Can lower the core and use 3.x plugin-pom if maintainers prefer
cc @dwnusbaum @bitwiseman