Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to set build as Not Built #8

Closed
wants to merge 0 commits into from

Conversation

sparkoo
Copy link
Contributor

@sparkoo sparkoo commented Sep 5, 2017

No description provided.

@sparkoo sparkoo mentioned this pull request Sep 13, 2017
@basil
Copy link
Member

basil commented Jun 15, 2018

I recently started maintaining this plugin and am starting to go through the PR backlog. This change looks good overall! There are only two more things I'd like to see before merging this PR:

  • Rebasing the PR against the latest code in master. This will necessitate removing the final marker from notBuiltIfFound and creating a new setter for this field (marked with @DataBoundSetter). As a courtesy warning, please don't change the constructor that is marked with @Deprecated, as that only exists for backwards compatibility purposes.
  • Adding new tests to TextFinderPublisherPipelineTest that exercise the feature. I'd suggest adding two new tests: one called notBuiltIfFoundInFile that mirrors unstableIfFoundInFile, and one called notBuiltIfFoundInConsole that mirrors unstableIfFoundInConsole. The implementation of these tests should be trivial if you follow the existing examples.

@sparkoo
Copy link
Contributor Author

sparkoo commented Jun 18, 2018

ah, I thought this was dead. I even ask myself for maintainership, but without any response.
Thanks, I'll update PR later today.

@sparkoo
Copy link
Contributor Author

sparkoo commented Jun 18, 2018

new PR #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants