-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Jenkins pipeline support #6
Conversation
* src/main/resources/hudson/plugins/textfinder/TextFinderPublisher/config.jelly: * src/main/resources/index.jelly:
* src/main/java/hudson/plugins/textfinder/TextFinderPublisher.java:
* pom.xml: * src/main/java/hudson/plugins/textfinder/TextFinderPublisher.java:
* src/main/java/hudson/plugins/textfinder/TextFinderPublisher.java:
Looks the checks are more strict than in the past, pull request check fails due to other files as far as I can tell |
* pom.xml:
* src/main/java/hudson/plugins/textfinder/TextFinderPublisher.java: * src/main/resources/hudson/plugins/textfinder/Messages.properties: * src/main/resources/hudson/plugins/textfinder/Messages_ja.properties:
* src/main/java/hudson/plugins/textfinder/TextFinderPublisher.java:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer that the commit messages follow the standard git pattern of having a blank line immediately after the first line. That makes the "git log" output and other output like it more readable. It seems particularly helpful in this case, where the lines after the first line seem to be a list of files changed, not more details about the commit.
Will keep the remark for the commit message in mind for future commits |
Any update on this pull request? It is badly needed for our pipeline build |
When you are using pipeline you can use the logContains() functionality, like:
|
I think the groovy post build plugin better covers this need, as noted by
Johnny. The manager. LogContains syntax has been enough for my need.
…On Mon, Jun 12, 2017, 3:12 AM Johnny Willemsen ***@***.***> wrote:
When you are using pipeline you can use the logContains() functionality,
like:
if(manager.logContains("\\[Autobuild Unstable\\]")) {
manager.buildUnstable()
}
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJkDaLSipJlxoJKL4N9DAo6E0ynyXPoks5sDQD8gaJpZM4KC3XG>
.
|
Hi guys, thanks for the feedback. From the documentation on the plugin site, the contains function is not whitelisted and thus needs admin approval. However when I go to Manage Jenkins > Script Approval, I don't see anything pending approval. Any ideas how this function is meant to be used? |
Can you explain why you're using contains rather than logContains? I believe the groovy code in the pipeline executes on the master. Requesting contains(file) will require that file exist on the master, even if your job ran on an agent that is not the agent. I think it may be easier to echo (or cat) the contents of the file you're trying to read into the build log, then use logContains() to read from the log. |
Hey! Will text finder ever be implemented? We have a need to parse Junit results without contamination of Jenkins log with test results' content:) |
There's no need to increase parent version to 2.17, add workflow dependencies or I just opened an other pull request, adding pipeline support in #10. |
I propose this pull request be closed in favor of #12 |
Attempt to add support for Jenkins pipeline support.