Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use WebClientUtil.waitForJSExec to wait for JavaScript #43

Merged
merged 1 commit into from
Jun 23, 2019
Merged

Use WebClientUtil.waitForJSExec to wait for JavaScript #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions src/test/java/hudson/plugins/textfinder/TextFinderPublisherFreestyleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

import com.gargoylesoftware.htmlunit.WebClientUtil;
import com.gargoylesoftware.htmlunit.html.HtmlForm;
import com.gargoylesoftware.htmlunit.html.HtmlPage;
import hudson.Functions;
Expand All @@ -14,8 +15,6 @@
import hudson.tasks.Shell;
import java.io.File;
import java.io.IOException;
import java.util.HashSet;
import java.util.Set;
import org.junit.Rule;
import org.junit.Test;
import org.jvnet.hudson.test.JenkinsRule;
Expand Down Expand Up @@ -144,18 +143,7 @@ public void createTextFinderViaWebClient() throws Exception {
page.getAnchorByText("Text Finder").click();

// Wait for the YUI JavaScript to load.
Set<String> requiredInputs = new HashSet<>();
requiredInputs.add("_.fileSet");
requiredInputs.add("_.regexp");
requiredInputs.add("_.succeedIfFound");
requiredInputs.add("_.unstableIfFound");
requiredInputs.add("_.notBuiltIfFound");
requiredInputs.add("_.alsoCheckConsoleOutput");
for (String requiredInput : requiredInputs) {
while (config.getInputsByName(requiredInput).isEmpty()) {
Thread.sleep(100);
}
}
WebClientUtil.waitForJSExec(page.getWebClient());

// Configure the Text Finder.
config.getInputByName("_.fileSet").setValueAttribute("file1");
Expand Down