Test with config file provider plugin #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins 2.289.1 is no longer supported by the Jenkins update center. Jenkins versions prior to 2.332.4 have multiple known security vulnerabilities. Over 80% of users of the most recent two releases of text finder plugin are running Jenkins 2.332.1 or newer. Chose 2.332.4 as the baseline rather than 2.346.3 because only about 60% of those who installed the most recent two releases are running 2.346.1 or newer.
Tests run successfully fine without this dependency when executed from the usual Apache Maven command line as in: $ `mvn clean verify` Tests fail when run in the BOM evaluation. They report that a class from the config file provider plugin could not be found. jenkinsci/bom#1435 (comment) provides details.
|
Looks right. Did you verify the effect on PCT in |
|
Released in 1.21. |
Just hoping it works. Had never done a build in bom with an unreleased plugin. |
You can file the proposed plugin PR as draft, wait for an incrementals deploy, then patch BOM to use that incremental version and test the result either locally or in a draft It is probably possible to do this entirely locally also. PCT supports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with config file provider plugin
Declare config file provider test dependency
Tests run successfully fine without this dependency when executed from the usual Apache Maven command line as in:
$
mvn clean verifyTests fail when run in the BOM evaluation. They report that a class from the config file provider plugin could not be found.
jenkinsci/bom#1435 (comment) provides details.
Also increments minimum Jenkins version to 2.332.4 in order to reduce maintenance burden.