Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Markdown syntax of Non proxy hosts and Proxy host #570

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

Dohbedoh
Copy link
Contributor

@Dohbedoh Dohbedoh commented Aug 12, 2024

Recently discovered that wildcard syntax including several * are mis-interpreted by Markdown parsers.. For example 10.1.*.* would be 10.1.. with a bold dot..

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Dohbedoh Dohbedoh added the bug label Aug 12, 2024
@Dohbedoh Dohbedoh requested a review from a team as a code owner August 12, 2024 05:45
@Dohbedoh Dohbedoh changed the title Fix Markdown syntax of Non proxy hosts Fix Markdown syntax of Non proxy hosts and Proxy host Aug 12, 2024
@Dohbedoh
Copy link
Contributor Author

Or maybe we should just fix this entire content. The markdown is borked in the file and Proxy configuration does not make sense in an update-center.md anymore (if it ever did)..

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far as it goes. Other changes could be follow-ups?

@jglick jglick added this pull request to the merge queue Aug 12, 2024
Merged via the queue into jenkinsci:master with commit ab510dc Aug 12, 2024
16 checks passed
@Dohbedoh Dohbedoh deleted the bugfix/proxy-syntax branch August 12, 2024 22:55
@PierreBtz
Copy link
Contributor

Or maybe we should just fix this entire content.

As far as changing things in depth, we could contemplate using a more machine friendly language :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants