Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching from ComponentCategory.CONTROLLER to AGENT in a couple of cases #497

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 15, 2023

Seemed to make more sense to me. Noticed while doing #496.

@jglick jglick requested a review from a team as a code owner November 15, 2023 21:29
@@ -79,7 +79,7 @@ public void addContents(@NonNull Container container) {
@NonNull
@Override
public ComponentCategory getCategory() {
return ComponentCategory.AGENT;
return ComponentCategory.AGENT; // TODO or LOGS?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think ComponentCategory.AGENT is a good fit here.

@Dohbedoh
Copy link
Contributor

Dohbedoh commented Nov 20, 2023

0.013 [id=77]	INFO	o.jvnet.hudson.test.JenkinsRule#createWebServer: Running on http://localhost:37059/jenkins/
   0.029 [id=90]	INFO	jenkins.InitReactorRunner$1#onAttained: Started initialization
   0.030 [id=96]	INFO	jenkins.InitReactorRunner$1#onAttained: Listed all plugins
   0.033 [id=92]	INFO	j.b.api.BouncyCastlePlugin#start: /home/jenkins/agent/workspace/ugins_support-core-plugin_PR-497/target/tmp/j h12565975100753706842/plugins/bouncycastle-api/WEB-INF/optional-lib not found; for non RealJenkinsRule this is fine and can be ignored.
   0.162 [id=93]	INFO	jenkins.InitReactorRunner$1#onAttained: Prepared all plugins
   0.164 [id=92]	INFO	jenkins.InitReactorRunner$1#onAttained: Started all plugins
   0.166 [id=92]	INFO	jenkins.InitReactorRunner$1#onAttained: Augmented all extensions
   0.238 [id=54]	WARNING	o.j.h.test.SimpleCommandLauncher#launch
java.io.IOException: Node slave0 has been deleted during the channel setup
	at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:696)
	at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:438)
	at org.jvnet.hudson.test.SimpleCommandLauncher.launch(SimpleCommandLauncher.java:82)
	at hudson.slaves.SlaveComputer.lambda$_connect$0(SlaveComputer.java:298)
	at jenkins.util.ContextResettingExecutorService$2.call(ContextResettingExecutorService.java:48)
	at jenkins.security.ImpersonatingExecutorService$2.call(ImpersonatingExecutorService.java:82)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
   0.333 [id=94]	INFO	jenkins.InitReactorRunner$1#onAttained: System config loaded
   0.349 [id=94]	INFO	jenkins.InitReactorRunner$1#onAttained: System config adapted
   0.350 [id=96]	INFO	jenkins.InitReactorRunner$1#onAttained: Loaded all jobs
   0.351 [id=96]	INFO	jenkins.InitReactorRunner$1#onAttained: Configuration for all jobs updated
   0.356 [id=91]	INFO	jenkins.InitReactorRunner$1#onAttained: Completed initialization
   0.392 [id=77]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Stopping Jenkins
   0.532 [id=77]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Jenkins stopped
   0.601 [id=77]	INFO	o.j.h.t.TemporaryDirectoryAllocator#dispose: deleting /home/jenkins/agent/workspace/ugins_support-core-plugin_PR-497/target/tmp/j h12565975100753706842

Some flaky test I guess, maybe this test needs a j.waitOnline(agent); after creating the agent .. I will run this again.

@Dohbedoh Dohbedoh merged commit 9d07659 into jenkinsci:master Nov 21, 2023
17 checks passed
@jglick jglick deleted the ComponentCategory.AGENT branch November 28, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants