[JENKINS-71722][JENKINS-71758] Respect globally configured period for Periodic generation

[Dohbedoh]

JENKINS-71722: global configuration (disablement and period) was not respected in the periodic generation.

Testing done

• Start Jenkins
• Configure a recurrence period of 2 hours
• Validate that periodic generation happens every 2 hours

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[jglick]

Looks like it would make the system property not work:

support-core-plugin/src/main/java/com/cloudbees/jenkins/support/config/SupportAutomatedBundleConfiguration.java

Lines 135 to 139 in 305a08c

	public void setPeriod(Integer period) {
	if (!isEnforcedPeriod()) {
	this.period = Math.max(Math.min(24, period), 1);
	} else {
	this.period = SupportPlugin.AUTO_BUNDLE_PERIOD_HOURS;

would honor it only if you saved config. I think it is rather

support-core-plugin/src/main/java/com/cloudbees/jenkins/support/config/SupportAutomatedBundleConfiguration.java

Lines 100 to 102 in 305a08c

	public int getPeriod() {
	return period;
	}

which should load the property if defined?

[Dohbedoh]

Right, testing this, the system property is not effective anymore. Maybe we should put the enforcement in the getter rather than the setter.

[Dohbedoh]

I have also noticed inconsistencies in the UI JENKINS-71758. I think it is best to fix this as part of this PR too.

[Dohbedoh]

Disabled that is enforced by com.cloudbees.jenkins.support.SupportPlugin.AUTO_BUNDLE_PERIOD_HOURS=0:

Period enforced by com.cloudbees.jenkins.support.SupportPlugin.AUTO_BUNDLE_PERIOD_HOURS=2:

[jglick]

This is going to suppress unrelated config like

support-core-plugin/src/main/java/com/cloudbees/jenkins/support/config/SupportAutomatedBundleConfiguration.java

Line 190 in 210c61f

setComponentIds(parseRequest(req, json));

?

[Dohbedoh]

It leaves the config untouched actually. I tested this.

• If you set -Dcom.cloudbees.jenkins.support.SupportPlugin.AUTO_BUNDLE_PERIOD_HOURS=0 and then go to the config page and save, it leaves the entire configuration as is (including com.cloudbees.jenkins.support.config.SupportAutomatedBundleConfiguration.xml). So that if you then remove the system property, you are back to your original configuration that you had.

• If you set -Dcom.cloudbees.jenkins.support.SupportPlugin.AUTO_BUNDLE_PERIOD_HOURS=2 and then go to the config page and save, it leaves only the period configuration as is (including com.cloudbees.jenkins.support.config.SupportAutomatedBundleConfiguration.xml). If you later remove the system property, the generation is still enabled and you are back to your original period value.

Does that makes sense ?

[jglick]

Whatever you say—I am not familiar with the details of this form.