Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HtmlUnit from 2.x to 3.x #471

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

timja-bot
Copy link

This is an autogenerated PR for updating HtmlUnit

It follows the migration guide

Migration steps for cases the script can't handle

This migration currently can't handle HtmlOption changes properly.
If it fails to compile on HtmlOption then revert the specific case:

--- a/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
+++ b/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
@@ -114,7 +114,7 @@ public class ExtendedEmailPublisherDescriptorTest {
      assertEquals(
              "Plain text should be selected by default",
              "text/plain",
-                contentType.getSelectedOptions().get(0).getValue());
+                contentType.getSelectedOptions().get(0).getValueAttribute());

Ping @timja if any questions

script source

@timja-bot timja-bot requested a review from a team as a code owner June 6, 2023 07:33
@timja-bot timja-bot added the dependencies Pull requests that update a dependency file label Jun 6, 2023
@jglick
Copy link
Member

jglick commented Jun 6, 2023

Will need to bump to 2.387.x and update bom.

@Dohbedoh
Copy link
Contributor

Proposed to use JenkinsConfiguredWithCodeRule instead that is the documented way to test CasC and can let us upgrade htmlunit without needing to bump bom and core version.

@Dohbedoh Dohbedoh merged commit 885fb04 into jenkinsci:master Jun 22, 2023
@Dohbedoh
Copy link
Contributor

@timja released in https://github.com/jenkinsci/support-core-plugin/releases/tag/1325.vb_a_6a_7b_c083a_d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants