Improve debugging support for annotation processors #575
Conversation
| String name = t.getQualifiedName().toString().replace('.', '/') + "/" + m.getSimpleName() + ".stapler"; | ||
| FileObject f = createResource(name); | ||
| notice("Generating " + name, m); |
There was a problem hiding this comment.
This was logging an object without a toString() method, which made it impossible to expect a specific value in the tests because the default Object#toString prints a memory address. By printing the name instead, we have a reliable thing to check for in tests, as well as prettier debug output.
|
Annotations in core PR diffs are quite noisy now due to what I suspect is a bug in |
|
I see. That is annoying indeed. We could always turn this logging back down (though the test cleanup I did could be retained), but I think it is preferable to roll forward and deal with any downstream issues to the degree it is practical. Otherwise, the next person to try to debug these annotation processors will be in the same undesirable position of getting no debug output. |
While recently attempting to debug an annotation processor, I found that all notices were being discarded, apparently due to an IntelliJ issue from 13 years ago that appears to have been resolved since then. This PR re-enables logging of notices and adapts the tests to expect them.
Testing done
mvn clean verify