Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use Guava's NullOutputStream #387

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

raul-arabaolaza
Copy link
Contributor

@raul-arabaolaza raul-arabaolaza commented Feb 22, 2022

Its location has been changed in Guava 14 meaning the tests of this plugin work fine with current baseline but fail with the PCT on the upcoming lts or when baseline is updated.

I could also wait for 2.332.1 to be released and then change the baseline and update the related Guava code, but I believe is simpler to just get rid of the related Guava usage in the test given how simple it is.

This does not affect production code but breaks any pipeline trying to run the PCT or the tests of this plugin with newer core versions

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Its location has been changed in Guava 14
Copy link
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is equivalent, looks good to me.

@basil
Copy link
Member

basil commented Feb 22, 2022

Another alternative to Guava's com.google.common.io.NullOutputStream is org.apache.commons.io.output.NullOutputStream.

@jglick
Copy link
Member

jglick commented Feb 22, 2022

@dwnusbaum remember you need to add a category label before merging for Release Drafter, and to trigger CD if appropriate.

@jglick
Copy link
Member

jglick commented Feb 22, 2022

Or just ByteArrayOutputStream discarding the result.

@jglick
Copy link
Member

jglick commented Feb 22, 2022

you need to add a category label before merging

If you forget, you can add the label later and manually trigger the workflow on master.

@car-roll car-roll added the test label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants