Jenkins-60214 Make plugin manager cli work with other update centers. Bug fixes. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leemeador
commented
Dec 30, 2019
leemeador
commented
- experimental update center URL - remove improperly embedded file name
- optional update center with unusual path in URL - compute correct path to plugin files
…, fix bug where no slash allowed on end of update center option
…ss. Make them static. Consolidate all tests into an appropriately named test class.
…pdate center json file name, require file name portion to be specified with full URL (as done in Jenkins itself)
…d with full URL (as done in Jenkins itself)
…te center, more tests, static imports, object versions of utils methods
# Conflicts: # plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java - merged
Fix bug where supplied non-jenkins.io URL with extended path calculated plugin location incorrectly Add and correct javadoc Move some classes to new util package
Fix bug where supplied non-jenkins.io URL with extended path calculated plugin location incorrectly Add and correct javadoc Move some classes to new util package
timja
reviewed
Jan 7, 2020
...management-library/src/main/java/io/jenkins/tools/pluginmanager/util/PluginManagerUtils.java
Outdated
Show resolved
Hide resolved
timja
approved these changes
Jan 10, 2020
|
Sorry for being late, and thanks for getting it over the line! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.