Stop storing the filename inside the .sha256 file
#676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor issue encountered when trying to consume the new SHA256 information from
jenkinsci/docker: I inadvertently included the filename in the.sha256file, which not only breaks Artifactory's convention, but also makes it more challenging to consume this value over there where we use a different file name. Simpler to follow Artifactory's convention and not include a filename, forcing the caller to handle this. Since we don't have any callers yet, better to do this now rather than have a migration later.Sorry for finding this after I already asked for a release...
Testing done
Ran the commands locally.