Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA256 checksum to GitHub release #675

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

basil
Copy link
Member

@basil basil commented May 1, 2024

  • Verify the SHA256 checksum when downloading from Artifactory
  • Publish the SHA256 checksum to GitHub releases so that consumers who download it from there may also verify

Testing done

Tested the changes to fetch-artifact end-to-end in GitHub Actions.

Did not test the changes to upload-release-asset, but those match our usage in Jenkins core and should be easy to debug in case of any issues the next time we perform a release.

@basil basil added the enhancement New feature or request label May 1, 2024
@basil basil requested a review from a team May 1, 2024 21:08
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've tested the fetch artifact bits locally in my shell.

would you like a release now?

@timja timja enabled auto-merge (squash) May 1, 2024 21:50
@basil
Copy link
Member Author

basil commented May 1, 2024

Sure, a release would be great as I intend to consume this from wherever we fetch this JAR. Thanks!

@timja timja merged commit 447cd95 into jenkinsci:master May 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants