Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix findPluginsToDownload falsely check installed version #657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anhcraft
Copy link

@anhcraft anhcraft commented Mar 9, 2024

I noticed that PluginManager#findPluginsToDownload has a wrong logic if-else. For a requested plugin, if there is both installed plugin and bundled plugin, then the method only gets the version from the installed one without checking if the bundled one is newer. The else logic was added in c445dea

Testing done

I have adjusted the test case to suit the new changes.

Submitter checklist

Tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant