Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --plugin-download-directory to docker example #618

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Add --plugin-download-directory to docker example #618

merged 2 commits into from
Nov 30, 2023

Conversation

aSky17
Copy link
Contributor

@aSky17 aSky17 commented Nov 30, 2023

Added download directory option in the docker example in README.md

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

MarkEWaite
MarkEWaite approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the example works with Alpina container. Had already confirmed it works with the container based on Debian

@MarkEWaite MarkEWaite merged commit 3a6bbb7 into jenkinsci:master Nov 30, 2023
15 checks passed
@aSky17 aSky17 deleted the supply-directory-option-to-docker-example branch December 1, 2023 04:35
@timja timja added the documentation Improvements or additions to documentation label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aSky17 @MarkEWaite @timja