Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a contributing guide #536

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Add a contributing guide #536

merged 4 commits into from
Feb 28, 2023

Conversation

AmanGupta677
Copy link
Contributor

Moved contribution related text from the end of the README to a new file and added a contributing topic in the readme file which point to the new CONTRIBUTING file.
fixes #529

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

MarkEWaite
MarkEWaite requested changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Some changes that need to be made.

CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@AmanGupta677
Copy link
Contributor Author

I have made the changes that you have requested.

MarkEWaite
MarkEWaite approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite added the documentation Improvements or additions to documentation label Feb 28, 2023
@MarkEWaite MarkEWaite changed the title README file modified (#529) Add a contributing guide Feb 28, 2023
@MarkEWaite MarkEWaite merged commit 3d3e5b4 into jenkinsci:master Feb 28, 2023
@AmanGupta677 AmanGupta677 deleted the aman branch February 28, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move developer instructions to a new contributing guide
2 participants
@AmanGupta677 @MarkEWaite