Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure explicit line termination for source files #512

Merged

Conversation

MarkEWaite
Copy link
Contributor

Configure explicit line termination for source files

Windows users that checkout with autocrlf=true would get Java source files that use CRLF line termination and then the formatting checks will fail due to the CRLF line termination.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Windows users that checkout with autocrlf=true would get Java source
files that use CRLF line termination and then the formatting checks
will fail due to the CRLF line termination.
@MarkEWaite MarkEWaite added the chore Project maintenance label Jan 14, 2023
@timja timja merged commit 7e34d09 into jenkinsci:master Jan 14, 2023
@MarkEWaite MarkEWaite deleted the add-gitattributes-to-force-formatting branch April 22, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants