Clean up build #468
Merged
Clean up build #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Aug 17, 2022
Comment on lines
+27
to
+35
| <groupId>com.github.spotbugs</groupId> | ||
| <artifactId>spotbugs-annotations</artifactId> | ||
| <optional>true</optional> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>com.google.code.findbugs</groupId> | ||
| <artifactId>jsr305</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
EOL JSR 305 as we have in other repositories; switch to SpotBugs JAR.
Comment on lines
+72
to
+77
| <exclusions> | ||
| <exclusion> | ||
| <groupId>com.google.code.findbugs</groupId> | ||
| <artifactId>jsr305</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
Consistent with other repositories, ban JSR 305.
Comment on lines
+80
to
+102
| <groupId>com.github.tomakehurst</groupId> | ||
| <artifactId>wiremock-jre8</artifactId> | ||
| <version>2.33.2</version> | ||
| <scope>test</scope> | ||
| <exclusions> | ||
| <exclusion> | ||
| <!-- Rely on jackson-annotations from jackson-dataformat-yaml --> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-annotations</artifactId> | ||
| </exclusion> | ||
| <exclusion> | ||
| <!-- Rely on jackson-databind from jackson-dataformat-yaml --> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.github.stefanbirkner</groupId> | ||
| <artifactId>system-rules</artifactId> | ||
| <version>1.19.0</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <groupId>com.github.stefanbirkner</groupId> | ||
| <artifactId>system-rules</artifactId> | ||
| <version>1.19.0</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Fixing incorrect indentation.
Comment on lines
-98
to
-111
| <build> | ||
| <pluginManagement> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-javadoc-plugin</artifactId> | ||
| <configuration> | ||
| <source>8</source> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </pluginManagement> | ||
| </build> | ||
|
|
There was a problem hiding this comment.
Redundant; already in the grandparent POM.
| <connection>scm:git:ssh://git@github.com/jenkinsci/plugin-installation-manager-tool.git</connection> | ||
| <developerConnection>scm:git:ssh://git@github.com/jenkinsci/plugin-installation-manager-tool.git</developerConnection> | ||
| <url>https://github.com/jenkinsci/plugin-installation-manager-tool</url> | ||
| <scm child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false" child.scm.url.inherit.append.path="false"> |
There was a problem hiding this comment.
Good for multi-module Maven projects.
Comment on lines
+31
to
+33
| <connection>scm:git:https://github.com/${gitHubRepo}.git</connection> | ||
| <developerConnection>scm:git:git@github.com:${gitHubRepo}.git</developerConnection> | ||
| <url>https://github.com/${gitHubRepo}</url> |
| <tag>${scmTag}</tag> | ||
| </scm> | ||
|
|
||
| <licenses> | ||
| <license> | ||
| <name>The MIT license</name> | ||
| <url>http://www.opensource.org/licenses/mit-license.php</url> | ||
| <url>https://opensource.org/licenses/MIT</url> |
Comment on lines
-60
to
-70
| <dependency> | ||
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <version>4.13.2</version> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest-core</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> |
There was a problem hiding this comment.
Redundant; in the parent POM.
Comment on lines
-81
to
-87
| <dependency> | ||
| <groupId>org.junit</groupId> | ||
| <artifactId>junit-bom</artifactId> | ||
| <version>5.9.0</version> | ||
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Redundant; in the parent POM.
timja
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.