Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable JUnit v5 #417

Merged
merged 5 commits into from
Mar 11, 2022
Merged

Enable JUnit v5 #417

merged 5 commits into from
Mar 11, 2022

Conversation

nhojpatrick
Copy link
Contributor

To make testing easier for #416 I want to use assertAll. So this add JUnit v5 support and updates PluginManager*Test(s). So the diff for #416 is clear.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@nhojpatrick nhojpatrick mentioned this pull request Mar 11, 2022
Open
6 tasks
@timja timja added the tests label Mar 11, 2022
@timja timja merged commit 8693165 into jenkinsci:master Mar 11, 2022
@nhojpatrick nhojpatrick deleted the feature/junit-v5 branch March 11, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhojpatrick @timja