Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve traceability of plugin dependency exception by printing #304

Merged

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Mar 5, 2021

dependency chain

This closes #302

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja
Copy link
Member

timja commented Mar 5, 2021

No test updates required?

Can you show actual output and testing instruction for a one-off test?

@kwin
Copy link
Contributor Author

kwin commented Mar 5, 2021

You can now check out with java -jar plugin-management-cli/target/jenkins-plugin-manager-2.8.1-SNAPSHOT.jar --plugins nabaztag:1.9 -d plugins/ --war ~/Downloads/jenkins.war --credentials abcd:acd:acd and it exposes now

Multiple plugin prerequisites not met:
Plugin nabaztag:1.9 Could not resolve dependencies: null

@timja
Copy link
Member

timja commented Mar 5, 2021

You can now check out with java -jar plugin-management-cli/target/jenkins-plugin-manager-2.8.1-SNAPSHOT.jar --plugins nabaztag:1.9 -d plugins/ --war ~/Downloads/jenkins.war --credentials abcd:acd:acd and it exposes now

Multiple plugin prerequisites not met:
Plugin nabaztag:1.9 Could not resolve dependencies: null

Is this correct?

Multiple plugin prerequisites not met

isn't that only one?

@kwin
Copy link
Contributor Author

kwin commented Mar 5, 2021

Yes, but this behaviour has not changed by this PR. I will try to improve the message.

make checksum exception also expose the dependency chain
@kwin kwin force-pushed the feature/improve-dependency-exception-message branch from 9a5d3be to 034fd8f Compare March 5, 2021 17:56
@kwin kwin force-pushed the feature/improve-dependency-exception-message branch from 07f4367 to fa32b5f Compare March 5, 2021 18:16
@timja timja added the enhancement New feature or request label Mar 5, 2021
@timja timja merged commit 7e2932c into jenkinsci:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose originally requested plugin name for message "Unable to find plugin xxx in update center yyy"
2 participants