Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve plugin list entries in the --list command #241

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Improve plugin list entries in the --list command #241

merged 1 commit into from
Dec 9, 2020

Conversation

oleg-nenashev
Copy link
Member

Set of all existing plugins and plugins that will be downloaded was a bit confusing, tried to reword it

@oleg-nenashev oleg-nenashev added the enhancement New feature or request label Dec 9, 2020
timja
timja approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better, I don't really think this should go under a --list option as that's confusing to be, tbh I would remove the option and just have it there by default.

--list to me means list installed plugins

@oleg-nenashev
Copy link
Member Author

Same for me @timja . I have already started #237 which would rework the CLI entirely, and this is definitely on my list. It makes sense to call it a dry-run command or so

@oleg-nenashev oleg-nenashev merged commit 1dd02eb into jenkinsci:master Dec 9, 2020
@oleg-nenashev oleg-nenashev deleted the list-command-clarify branch December 9, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleg-nenashev @timja