Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JENKINS_UC_DOWNLOAD, allows overriding plugin download URL #192

Merged
merged 6 commits into from
Sep 17, 2020
Merged

Add JENKINS_UC_DOWNLOAD, allows overriding plugin download URL #192

merged 6 commits into from
Sep 17, 2020

Conversation

oganga
Copy link
Contributor

@oganga oganga commented Sep 16, 2020

Possible fix for #191

jetersen
jetersen reviewed Sep 16, 2020
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While your at it, use isNotEmpty and fix formatting

plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java Outdated Show resolved Hide resolved
@jetersen
Copy link
Member

Så fortjener du lige en. Skide godt, Thorkild! 😆

@oganga @jetersen
Update plugin-management-library/src/main/java/io/jenkins/tools/plugi…
5ca1371 
…nmanager/impl/PluginManager.java

Co-authored-by: Joseph Petersen <josephp90@gmail.com>
timja
timja reviewed Sep 17, 2020
View reviewed changes
Copy link
Member

@timja timja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs docs (add a line in the README.md) about it

@timja timja added the enhancement New feature or request label Sep 17, 2020
@timja timja changed the title Not able to download plugins through private repo Add JENKINS_UC_DOWNLOAD, allows overriding plugin download URL Sep 17, 2020
@oganga
Copy link
Contributor Author

oganga commented Sep 17, 2020

@timja Yes, regarding the doc,, I am still a bit unsure if env var is the correct way of doing it or you(the project) would prefer a command line flag?
There is a bt more work in doing the command line flag.

timja
timja reviewed Sep 17, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@timja timja requested a review from jetersen September 17, 2020 19:36
@timja timja merged commit e6e9840 into jenkinsci:master Sep 17, 2020
@oganga
Copy link
Contributor Author

oganga commented Sep 18, 2020

What is the time frame to get this in an release and into the Jenkins Docker image?
Just to get an idea of if we should wait or do some in house manual stuff to fix our issue.

@timja
Copy link
Member

timja commented Sep 18, 2020

released, PR here for adding to the docker image:
jenkinsci/docker#992

you can easily override it by redownloading the jar with the updated version in the meantime

@oganga
Copy link
Contributor Author

oganga commented Sep 18, 2020

Cool!!
Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@jetersen jetersen Awaiting requested review from jetersen

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oganga @jetersen @timja