Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set tag name format to just be the project version #187

Merged
merged 3 commits into from
Sep 12, 2020
Merged

Set tag name format to just be the project version #187

merged 3 commits into from
Sep 12, 2020

Conversation

timja
Copy link
Member

@timja timja commented Sep 12, 2020

No description provided.

@timja timja added the chore Project maintenance label Sep 12, 2020
@timja
Copy link
Member Author

timja commented Sep 12, 2020

Untested

@jetersen
Copy link
Member

it works pretty well here: https://github.com/jenkinsci/configuration-as-code-plugin/blob/78628c0dfa864c56dacf1a15c8df5a52b70b39fc/pom.xml#L26

jetersen
jetersen reviewed Sep 12, 2020
View reviewed changes
pom.xml Outdated
<plugin>
<artifactId>maven-release-plugin</artifactId>
<configuration combine.children="append">
<tagNameFormat>@{project.version}</tagNameFormat>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure you do not need to go though plugin. Just use the property?

@timja timja requested a review from jetersen September 12, 2020 19:21
jetersen
jetersen approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja merged commit 561d494 into master Sep 12, 2020
@timja timja deleted the tag-name-format branch September 12, 2020 19:57
oleg-nenashev
oleg-nenashev reviewed Sep 12, 2020
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC there was a bug with MRP property resolution at some point, but I do not see why it would not work now. It worth giving it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev left review comments

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
chore Project maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timja @jetersen @oleg-nenashev