Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that version is shown without PowerMock #127

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

stefanbirkner
Copy link
Contributor

Overriding the method that provides that provides the InputStream
increases test coverage and is less intrusive than PowerMock.

Overriding the method that provides that provides the InputStream
increases test coverage and is less intrusive than PowerMock.
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@timja timja added the chore Project maintenance label Jul 11, 2020
@timja timja merged commit 6cbe184 into jenkinsci:master Jul 11, 2020
@oleg-nenashev
Copy link
Member

+1. I do not think that PowerMock is actually needed for any test in the current test suite

@stefanbirkner stefanbirkner deleted the properties-without-powermock branch July 11, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants