Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workarounds introduced in #510 #701

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

basil
Copy link
Member

@basil basil commented Aug 28, 2024

Fixes #562

Testing done

Successfully tested this PR in jenkinsci/bom.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@basil basil added the internal label Aug 28, 2024
@basil basil force-pushed the legacy branch 3 times, most recently from 2829f7f to bec4616 Compare August 28, 2024 19:02
basil added a commit to basil/bom that referenced this pull request Aug 28, 2024
@basil basil requested a review from jtnord August 28, 2024 20:47
@basil basil marked this pull request as ready for review August 28, 2024 20:47
@basil basil requested a review from a team as a code owner August 28, 2024 20:47
Copy link
Member

@jtnord jtnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved assuming all plugins that are tested by the PCT have been updated.

@basil
Copy link
Member Author

basil commented Aug 29, 2024

Successfully tested this PR in jenkinsci/bom.

🤷‍♂️

@basil basil merged commit d1b0a49 into jenkinsci:master Aug 29, 2024
14 checks passed
@basil basil deleted the legacy branch August 29, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove workarounds introduced in #510
2 participants