Fix JUnit 5 tests when overriding test harness #685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After jenkinsci/pom#575 the test harness now depends on a new version of JUnit. When using this new test harness against older plugins that are compiled with an old version of JUnit, upper bounds analysis kicks in and upgrades JUnit 5 at runtime, which now results in a different version of JUnit 5 being used at runtime vs compile time, which causes errors like this:
This PR fixes the issue by excluding JUnit 5 from upper bounds analysis.
Testing done
Reproduced the above failure and could no longer reproduce with this PR.