Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PCT Jenkinsfile to use versions uppper than Java 11 #669

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

imonteroperez
Copy link
Contributor

Highlights

[2024-06-11T07:46:53.146Z] [ERROR] Detected JDK version 11.0.23 (JAVA_HOME=/opt/jdk-11) is not in the allowed range [17,).
[2024-06-11T07:46:53.146Z] [ERROR] -> [Help 1]
[2024-06-11T07:46:53.146Z] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (display-info) on project plugins-compat-tester-cli: 
[2024-06-11T07:46:53.146Z] Rule 2: org.apache.maven.enforcer.rules.version.RequireJavaVersion failed with message:
[2024-06-11T07:46:53.147Z] Detected JDK version 11.0.23 (JAVA_HOME=/opt/jdk-11) is not in the allowed range [17,).

Testing done

  • Current PR builder

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@imonteroperez imonteroperez self-assigned this Jun 11, 2024
@imonteroperez imonteroperez requested a review from a team as a code owner June 11, 2024 07:54
@imonteroperez imonteroperez changed the title Update PCT Jenkinsfile to use only Java 17 Update PCT Jenkinsfile to use versions uppper than Java 11 Jun 11, 2024
@imonteroperez imonteroperez merged commit d53f79e into master Jun 11, 2024
14 checks passed
@imonteroperez imonteroperez deleted the java-17 branch June 11, 2024 08:18
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me. While we could remain on Java 11 for a little while longer, as we are in Remoting (because we continue to support Java 11 agents for LTS releases until October), there does not seem to be a compelling reason to do so here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants