Support testing SNAPSHOTs that have a deterministic git revision #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
SNAPSHOT
build is in the override war and it was built with a version ofmaven-hpi-plugin
3.42
or higher (jenkinsci/maven-hpi-plugin#436) then we have a concrete git sha we can use for checkout of the plugin.So this relaxes the enforcement of not building non releases by allowing to test a SNAPSHOT also so long as we have a git commit for it.
in the case the commit is HEAD (which is set by the legacy plugin extractors) then we will refuse to test the plugin the same as we do today.
Testing done
2.25-JTN-SNAPSHOT
2.25-JTN-20230512.152321-1
)I manually inspected the resulting logs and ensured that:
maven-hpi-plugin
to use the SNAPSHOT version of the dependencye.g.
Submitter checklist