Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract common process execution to a method #541

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Apr 28, 2023

almost the same code was called 3 times in a row when cloning, extracted to a common method to call.

validated the failure case manually with an old plugin using the git:// protocol

failed with

2023-04-28 17:21:26.405+0000 [id=1]     INFO    o.j.t.test.PluginCompatTester#cloneImpl: Checking out from Git repository git://github.com/jenkinsci-cert/secure-requester-whitelist-plugin.git at secure-requester-whitelist-1.7
org.jenkins.tools.test.exception.PluginSourcesUnavailableException: git fetch git://github.com/jenkinsci/secure-requester-whitelist-plugin.git secure-requester-whitelist-1.7 failed with exit status 128: fatal: unable to connect to github.com:
github.com[0: 140.82.113.4]: errno=Unknown error
        at org.jenkins.tools.test.PluginCompatTester.runCommand(PluginCompatTester.java:574)
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord jtnord requested a review from a team as a code owner April 28, 2023 17:27
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jtnord jtnord merged commit dd5360e into master May 2, 2023
@jtnord jtnord deleted the extract-common-code branch May 2, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants