Introduce a HookOrder annotation to order hooks
#521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a HookOrder that allows the hooks to be run in an order not determined by their classname. Using classname mean that external hooks would need to be put in multiple packages depending on if they needed to come before or after a given hook from OSS - and it also makes it possible to use better names for hooks in OSS. Currently not needed but extracted from jenkinsci#510
basil
approved these changes
Apr 11, 2023
basil
changed the title
HookOrder annotation to order hooks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
HookOrderthat allows the hooks to be run in an order not determined by their classname.Using classname mean that external hooks would need to be put in multiple packages depending on if they needed to come before or after a given hook from OSS - and it also makes it possible to use better names for hooks in OSS.
Currently not needed but extracted from #510