Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UpdateSite into PCT package #501

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Move UpdateSite into PCT package #501

merged 1 commit into from
Mar 24, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 23, 2023

Now that jenkins-core is back on the test classpath (just for Dependabot!) it seems safer to move this class into the PCT package to prevent any risk of conflict while running this repository's tests. @jtnord this will require a trivial update to the import in CloudBeesModulesHook, hence the breaking label.

@basil basil added the breaking label Mar 23, 2023
@basil basil requested a review from a team as a code owner March 23, 2023 03:37
@basil basil requested a review from jtnord March 23, 2023 18:38
Copy link
Member Author

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two days with no acknowledgment.

@basil basil merged commit b779758 into master Mar 24, 2023
@basil basil deleted the UpdateSite branch March 24, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant