Fail fast when attempting to run PCT against a release with a missing or nondeterministic tag #499
Conversation
… or nondeterministic tag
|
Tested successfully in jenkinsci/bom#1880. |
| public void action(@NonNull BeforeCheckoutContext context) | ||
| throws PluginSourcesUnavailableException { | ||
| Model model = context.getModel(); | ||
| if (model.getScm().getTag() == null || model.getScm().getTag().equals("HEAD")) { |
There was a problem hiding this comment.
I have a feeling this breaks --local-checkout-dir for regular (non multi-module) plugins which is a used developer flow to check compatability without having to constantly rebuild a war?
There was a problem hiding this comment.
Not sure. --local-checkout-dir doesn't really work for the local development use case anyway since PCT deletes the whole Git repository before cloning: I'd be too afraid to point it to my local directory out of fear of losing all my local branches. And in automation it's not used at all in jenkinsci/bom and used more or less in ignorance of the correct approach in proprietary consumers.
I'm inclined to let it break for now. Once the dust has settled with multimodule support, which I think should include ripping --local-checkout-dir from all automation, I'll look into getting it to work again in an intuitive fashion for the local development use case.
|
In the latest revision I have made this run only when |
#496 but filed against the proper origin. See #496 for the description.