Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multi-parent hooks to wok with --local-checkout-dir #492

Closed
wants to merge 2 commits into from

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Mar 17, 2023

improves multi-parent hooks to work with a local checkout when testing a single plugin

tested with the aws-java-sdk-minimal plugin in a local checkout.

--working-dir=c:\workarea\source\github\cloudbees\unified-release\output-oc-it\work
--war=c:\workarea\source\github\cloudbees\unified-release\products\core-cm\target\core-cm.war
--fallback-github-organization=jenkinsci-cert
--external-hooks-jars=c:\workarea\source\github\cloudbees\unified-release\tests\cb-pct-hooks\target\cb-pct-hooks.jar
--include-plugins=oc-it
--local-checkout-dir=c:\workarea\source\github\cloudbees\unified-release\.\tests\operations-center-it
-Dsurefire.excludesFile=c:\workarea\source\github\cloudbees\unified-release/src/test/resources/pct-surefire-exclusion-list
-Dsurefire.rerunFailingTestsCount=0
-DreuseForks=false
-DforkCount=1
-Dmaven.test.failure.ignore=true

needs further testing

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

improves multi-parent hooks to work with a local checkout when testing a
single plugin

tested with the aws-java-sdk-minimal plugin in a local checkout.
@@ -131,7 +131,7 @@ public void testPlugins() throws PluginCompatibilityTesterException {
&& localCheckoutProvided()
&& !data.plugins.containsKey(config.getIncludePlugins().get(0))) {
String artifactId = config.getIncludePlugins().get(0);
UpdateSite.Plugin extracted = extractFromLocalCheckout();
UpdateSite.Plugin extracted = extractFromLocalCheckout(artifactId);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was broken as the plugin name would be set to the artifactId of the root of the checkout which for multimodule projects is always wrong.

as we are only testing a single pluign we know the name which is the artifactId so use it.

@jtnord
Copy link
Member Author

jtnord commented Apr 13, 2023

mostly obsolete by #510 , some work is still required but to do in a different PR

@jtnord jtnord closed this Apr 13, 2023
@jtnord jtnord deleted the local-checkout-and-multi-module branch April 26, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant